Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frame v2 upgrade part1 #1771

Open
wants to merge 44 commits into
base: MESH-/pips
Choose a base branch
from
Open

Frame v2 upgrade part1 #1771

wants to merge 44 commits into from

Conversation

Neopallium
Copy link
Contributor

@Neopallium Neopallium commented Dec 17, 2024 •
edited
Loading

This PR tries to de-tangle the pallet dependencies by moving code out of the pallets/common crate (polymesh-common-utilities).

The common crate has the follow:

  1. Common types. These should be moved to our polymesh-primitives crate.
  2. Custom traits we use to do "soft" linking between our pallets (like the PortfolioSubTrait).
  3. Helper functions like with_transaction. Should be moved to our polymesh-primitives crate.
  4. Benchmark helpers (like UserBuilder). This depends a lot on our Identity pallet, so maybe move it there.
  5. Common constants (like the SystematicIssuers and genesis DIDs). Moved to polymesh-primitives.

Changes:

  1. Move common constants and types from polymesh-common-utilities to polymesh-primitives.
  2. Move WeightInfo, Config and decl_event types from polymesh-common-utilities into the pallet that they belong to.

@Neopallium Neopallium force-pushed the frame_v2_upgrade_part1 branch 2 times, most recently from 8f3ee77 to 0006fff Compare December 18, 2024 14:57
Base automatically changed from remove_old_v7_migrations to develop December 19, 2024 12:33
@adamdossa adamdossa changed the title [WIP] Frame v2 upgrade part1 Frame v2 upgrade part1 Dec 19, 2024
@Neopallium Neopallium force-pushed the frame_v2_upgrade_part1 branch from 1a5a223 to 5a3c14b Compare December 19, 2024 15:43
@Neopallium Neopallium changed the base branch from develop to asset-ticker-migration December 19, 2024 15:43
This was referenced Dec 19, 2024
Closed
Closed
Closed
Closed
Base automatically changed from asset-ticker-migration to develop December 27, 2024 12:21
@Neopallium Neopallium force-pushed the frame_v2_upgrade_part1 branch 2 times, most recently from 7fa260f to f5251ac Compare December 31, 2024 10:02
@Neopallium Neopallium changed the base branch from develop to frame_v2_upgrade_pips December 31, 2024 10:02
@Neopallium Neopallium force-pushed the frame_v2_upgrade_part1 branch from f5251ac to 6cbba32 Compare December 31, 2024 10:29
Neopallium and others added 27 commits December 31, 2024 22:17
@Neopallium
Move AssetFnTrait and asset bench helpers to primitives.
0b3677b
@Neopallium
Move WeightInfo, Config, Events into ExternalAgent pallet.
4bbe12a
@Neopallium
Move WeightInfo, Config, Event into relayer pallet.
836246d
@Neopallium
Move Context type to Identity pallet.
ac235ec
@Neopallium
Move more traits to primitives.
d9e6e5f
@Neopallium
Move WeightInfo into MultiSig pallet.
fa763c3
@Neopallium
Move WeightInfo, Config, Event into Group pallet.
f0f8446
@Neopallium
Move WeightInfo, Config, Event into NFT pallet.
476ced1
@Neopallium
Move WeightInfo, Config, Event into Portfolio pallet.
839eda6
@Neopallium
Move WeightInfo, Config, Event into Statistics pallet.
9c54915
@Neopallium
Move WeightInfo, Event into Settlement pallet.
fcbc758
@Neopallium
Move WeightInfo, Config, Event into Compliance Manager pallet.
7799eb1
@Neopallium
Remove unneeded deps.
10d7a52
@Neopallium
Remove unused trait.
e1af7cc
@Neopallium
Move CheckCdd trait to primitives.
d758fdb
@Neopallium
Move WeightInfo, Config, Event, LockableCurrencyExt, AccountData into…
59587b5 
… Balances pallet.
@Neopallium
Remove some unused deps.
81badab
@Neopallium
Move WeightInfo, Config, Event into Asset/Checkpoint pallet.
c1b3f3b
@Neopallium
Remove polymesh-common-utilities.
dceb097
@Neopallium
Bump polymesh-api deps.
469b7c0
@Neopallium
Remove unused feature 'default_identity'.
ad094a9
@Neopallium
Update 7.1 metadata.
451241b
@Neopallium
Bump anstream.
1cb3ae7
@Neopallium
Bump yarn deps.
eb1002c
@Neopallium
Update v7.1 testnet/mainnet metadata.
eb112ad
@CsB-Polymesh @Neopallium
Remove bridge from readme
629fe12
@Neopallium
Remove useless Context test.
eb72eac
@Neopallium Neopallium force-pushed the frame_v2_upgrade_part1 branch from 6cbba32 to eb72eac Compare December 31, 2024 14:19
@Neopallium Neopallium changed the base branch from frame_v2_upgrade_pips to MESH-/pips December 31, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HenriqueNogara HenriqueNogara HenriqueNogara approved these changes

@adamdossa adamdossa Awaiting requested review from adamdossa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Neopallium @HenriqueNogara @CsB-Polymesh