fix: rotate session id when reset is called (#168)

CHANGELOG.md

@@ -1,6 +1,7 @@
 ## Next
 
 - recording: expose session id ([#166](https://github.com/PostHog/posthog-android/pull/166))
+- fix: rotate session id when reset is called ([#168](https://github.com/PostHog/posthog-android/pull/168))
 - feat: add `$is_identified` property ([#167](https://github.com/PostHog/posthog-android/pull/167))
 - fix: identify should not allow already identified users ([#167](https://github.com/PostHog/posthog-android/pull/167))
 

posthog/src/main/java/com/posthog/PostHog.kt

@@ -687,6 +687,7 @@ public class PostHog private constructor(
         }
 
         endSession()
+        startSession()
     }
 
     private fun isEnabled(): Boolean {

posthog/src/test/java/com/posthog/PostHogTest.kt

@@ -1045,7 +1045,7 @@ internal class PostHogTest {
     }
 
     @Test
-    fun `does not set session id when reset is called`() {
+    fun `reset session id when reset is called`() {
         val http = mockHttp()
         val url = http.url("/")
 
@@ -1069,7 +1069,8 @@ internal class PostHogTest {
         var batch = serializer.deserialize<PostHogBatchEvent>(content.reader())
 
         var theEvent = batch.batch.first()
-        assertNotNull(theEvent.properties!!["\$session_id"])
+        val currentSessionId = theEvent.properties!!["\$session_id"]
+        assertNotNull(currentSessionId)
 
         sut.reset()
 
@@ -1091,7 +1092,10 @@ internal class PostHogTest {
         batch = serializer.deserialize<PostHogBatchEvent>(content.reader())
 
         theEvent = batch.batch.first()
-        assertNull(theEvent.properties!!["\$session_id"])
+        val newSessionId = theEvent.properties!!["\$session_id"]
+        assertNotNull(newSessionId)
+
+        assertTrue(currentSessionId != newSessionId)
 
         sut.close()
     }