fix: do not clear events and reload flags after reset is called (#170)

PostHog · Aug 30, 2024 · 9012e5d · 9012e5d
1 parent bb0f3d3
commit 9012e5d
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 ## Next
 
+- fix: do not clear events when reset is called ([#170](https://github.com/PostHog/posthog-android/pull/170))
+- fix: reload feature flags as anon user after reset is called ([#170](https://github.com/PostHog/posthog-android/pull/170))
+
 ## 3.6.0 - 2024-08-29
 
 - recording: expose session id ([#166](https://github.com/PostHog/posthog-android/pull/166))

diff --git a/posthog/src/main/java/com/posthog/PostHog.kt b/posthog/src/main/java/com/posthog/PostHog.kt
@@ -678,16 +678,19 @@ public class PostHog private constructor(
         val except = listOf(VERSION, BUILD)
         getPreferences().clear(except = except)
         featureFlags?.clear()
-        queue?.clear()
-        replayQueue?.clear()
         featureFlagsCalled.clear()
-
         synchronized(identifiedLock) {
             isIdentifiedLoaded = false
         }
 
         endSession()
         startSession()
+
+        // reload flags as anon user
+        // only because of testing in isolation, this flag is always enabled
+        if (reloadFeatureFlags) {
+            reloadFeatureFlags()
+        }
     }
 
     private fun isEnabled(): Boolean {

diff --git a/posthog/src/test/java/com/posthog/PostHogTest.kt b/posthog/src/test/java/com/posthog/PostHogTest.kt
@@ -1049,7 +1049,7 @@ internal class PostHogTest {
         val http = mockHttp()
         val url = http.url("/")
 
-        val sut = getSut(url.toString(), preloadFeatureFlags = false)
+        val sut = getSut(url.toString(), preloadFeatureFlags = false, reloadFeatureFlags = false)
 
         sut.capture(
             EVENT,
@@ -1100,6 +1100,24 @@ internal class PostHogTest {
         sut.close()
     }
 
+    @Test
+    fun `reset reloads flags as anon user`() {
+        val http = mockHttp()
+        val url = http.url("/")
+
+        val sut = getSut(url.toString(), preloadFeatureFlags = false)
+
+        sut.reset()
+
+        featureFlagsExecutor.shutdownAndAwaitTermination()
+
+        val request = http.takeRequest()
+        assertEquals(1, http.requestCount)
+        assertEquals("/decide/?v=3", request.path)
+
+        sut.close()
+    }
+
     @Test
     fun `logger uses System out by default`() {
         val http = mockHttp()