add comments and pending classes, features

.gitignore

@@ -152,4 +152,7 @@ build/
 gradle-app.setting
 
 # Jacoco
-/posthog/jacoco.exec
+/posthog/jacoco.exec
+
+# eclipse
+.project/

posthog-v3/posthog-android/src/main/java/com/posthog/android/internal/PostHogActivityLifecycleCallback.kt

@@ -0,0 +1,6 @@
+package com.posthog.android.internal
+
+// ActivityLifecycleCallbacks, IntegrationOperation, PostHogActivityLifecycleCallbacks
+internal class PostHogActivityLifecycleCallback {
+    // TODO: lifecycle events, deeplinks, record screen views
+}

posthog-v3/posthog-android/src/main/java/com/posthog/android/internal/PostHogAdvertisingIdReader.kt

@@ -0,0 +1,5 @@
+package com.posthog.android.internal
+
+// GetAdvertisingIdTask
+class PostHogAdvertisingIdReader {
+}

posthog-v3/posthog/src/main/java/com/posthog/PostHog.kt

@@ -79,6 +79,7 @@ public class PostHog {
         properties?.let {
             props.putAll(it)
         }
+        // TODO: message_id=messageId
 
         // distinctId is always present but it has to be nullable because the SDK may be disabled
         // TODO: missing static, dynamic context
@@ -136,6 +137,7 @@ public class PostHog {
 
         // TODO: reset feature flags, set anonymousId and distinctId
 //        val oldDistinctId = this.distinctId
+        // TODO: userProperties
 
         val props = mutableMapOf<String, Any>()
         props["distinct_id"] = distinctId
@@ -156,6 +158,7 @@ public class PostHog {
         if (!isEnabled()) {
             return
         }
+        // TODO: groupProperties, event $groupidentify
     }
 
     public fun reloadFeatureFlagsRequest() {
@@ -265,5 +268,6 @@ public class PostHog {
         }
 
         // TODO: add other methods
+        // TODO: is Stats a feature or just used by tests in posthog-android
     }
 }

posthog-v3/posthog/src/main/java/com/posthog/PostHogConfig.kt

@@ -14,6 +14,7 @@ public class PostHogConfig(
     public var flushIntervalSeconds: Int = 30,
 
     public var dataMode: PostHogDataMode = PostHogDataMode.ANY,
+    public var encryption: PostHogEncryption = PostHogEncryption.PostHogEncryptionNone()
 ) {
     internal var logger: PostHogLogger? = null
 

posthog-v3/posthog/src/main/java/com/posthog/PostHogEncryption.kt

@@ -0,0 +1,21 @@
+package com.posthog
+
+import java.io.InputStream
+import java.io.OutputStream
+
+public abstract class PostHogEncryption {
+    public abstract fun decrypt(inputStream: InputStream): InputStream
+
+    public abstract fun encrypt(outputStream: OutputStream): OutputStream
+
+    internal class PostHogEncryptionNone : PostHogEncryption() {
+        override fun decrypt(inputStream: InputStream): InputStream {
+            return inputStream
+        }
+
+        override fun encrypt(outputStream: OutputStream): OutputStream {
+            return outputStream
+        }
+
+    }
+}

posthog-v3/posthog/src/main/java/com/posthog/internal/PostHogApi.kt

@@ -21,10 +21,13 @@ internal class PostHogApi(private val config: PostHogConfig) {
     private val mediaType = "application/json; charset=utf-8".toMediaType()
     private val gson = GsonBuilder().apply {
         registerTypeAdapter(Date::class.java, GsonDateTypeAdapter(config))
+            .setLenient()
     }.create()
     private val gsonBatchBodyType = object : TypeToken<PostHogBatchEvent>() {}.type
     private val gsonDecideBodyType = object : TypeToken<Map<String, Any>>() {}.type
 
+    // TODO: do we care about max queue size? apparently theres a 500kb hardlimit on the server
+
     fun batch(events: List<PostHogEvent>) {
         val batch = PostHogBatchEvent(config.apiKey, events)
 //        """
@@ -39,11 +42,15 @@ internal class PostHogApi(private val config: PostHogConfig) {
 //      "timestamp": "2023-09-13T12:05:30.326Z"
 //    }
 //  ],
-//  "timestamp": "2023-09-13T12:05:30.326Z"
+//  "timestamp": "2023-09-13T12:05:30.326Z",
+//  "sent_at": "2023-09-13T12:05:30.326Z",
 // }
 //        """.trimIndent()
         val request = makeRequest("${config.host}/batch") {
-            gson.toJson(batch, gsonBatchBodyType, it.bufferedWriter())
+            val writer = it.bufferedWriter()
+            batch.sentAt = Date()
+            gson.toJson(batch, gsonBatchBodyType, writer)
+            writer.flush()
         }
 
         client.newCall(request).execute().use {
@@ -89,6 +96,7 @@ internal class PostHogApi(private val config: PostHogConfig) {
         }
 
         client.newCall(request).execute().use {
+            // TODO: do we handle 429 differently?
             if (!it.isSuccessful) throw PostHogApiError(it.code, it.message, body = it.body)
 
             it.body?.let { body ->

posthog-v3/posthog/src/main/java/com/posthog/internal/PostHogBatchEvent.kt

@@ -9,4 +9,6 @@ internal data class PostHogBatchEvent(
     val apiKey: String,
     val batch: List<PostHogEvent>,
     val timestamp: Date = Date(),
+    @SerializedName("sent_at")
+    var sentAt: Date? = null,
 )

posthog-v3/posthog/src/main/java/com/posthog/internal/PostHogStorage.kt

@@ -4,6 +4,11 @@ import com.posthog.PostHogConfig
 
 internal class PostHogStorage(private val config: PostHogConfig) {
     // TODO: move to disk cache instead of memory cache
+    // File folder = context.getDir("posthog-disk-queue"/tag(apiKey), Context.MODE_PRIVATE);
+    // /data/user/0/com.posthog.myapplication/app_posthog-disk-queue/_6SG-F7I1vCuZ-HdJL3VZQqjBlaSb1_20hDPwqMNnGI.tmp
+    // application.getSharedPreferences("posthog-android", Context.MODE_PRIVATE) - legacy
+    // context.getSharedPreferences("posthog-android-" + tag, MODE_PRIVATE)
+    // eg posthog-android-_6SG-F7I1vCuZ-HdJL3VZQqjBlaSb1_20hDPwqMNnGI
     private val keyValues = mutableMapOf<String, Any>()
     private val lock = Any()