feat: add emulator detection property to static context #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented `isEmulator` method to detect if the app is running on an emulator. - Integrated emulator detection into the static context cache. - Added assertions to verify emulator detection in static context. - Ensured static context includes the new `\$is_emulator` property.
thisames
commented
Aug 7, 2024
posthog-android/src/main/java/com/posthog/android/internal/PostHogAndroidContext.kt
Show resolved
Hide resolved
|
@thisames please add a changelog entry =) |
|
@thisames would you be willing to add to our taxonomy on the backend/frontend as well? See example https://github.com/PostHog/posthog/blob/46e6624cd9b314c67cd1f076f41eda901cd9b1f6/frontend/src/lib/taxonomy.tsx#L844-L848 |
sure! |
marandaneto
approved these changes
Aug 8, 2024
This was referenced Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds emulator detection to the static context and updates the tests to verify this functionality.
isEmulatormethod to detect if the app is running on an emulator.\$is_emulatorproperty.Motivation and Context
A crucial property for future use as a filter.
#113
How Has This Been Tested?
The tests have been updated to include checks for the new
\$is_emulatorproperty in the static context.I tested it manually on both an emulator and a physical device.
Checklist