Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: sdk info in recordings #172

Merged
merged 4 commits into from
Sep 12, 2024
Merged

chore: sdk info in recordings #172

merged 4 commits into from
Sep 12, 2024

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Sep 11, 2024 •
edited
Loading

💡 Motivation and Context

Recordings were appending groups wrongly
Recordings didn't have SDK info

#skip-changelog since its not a user facing change

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto marandaneto requested a review from a team September 11, 2024 14:48
@marandaneto marandaneto marked this pull request as ready for review September 11, 2024 14:48
@marandaneto marandaneto mentioned this pull request Sep 11, 2024
Merged
4 tasks
@marandaneto marandaneto merged commit e797bd0 into main Sep 12, 2024
5 checks passed
@marandaneto marandaneto deleted the chore/sdk-info-recording branch September 12, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daibhin daibhin daibhin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marandaneto @daibhin