feat: public uploads #18295
Closed
feat: public uploads #18295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daibhin
commented
Oct 31, 2023
daibhin
commented
Oct 31, 2023
| try: | ||
| file = request.data["file"] | ||
|
|
||
| if file.size > (FOUR_MEGABYTES * 20): |
daibhin
commented
Oct 31, 2023
| @@ -125,11 +125,10 @@ def format_paginated_url(request: request.Request, offset: int, page_size: int, | |||
|
|
|||
| def get_token(data, request) -> Optional[str]: | |||
| token = None | |||
| if request.method == "GET": | |||
There was a problem hiding this comment.
Mobile SDK was passing the api_key as a query param but in a POST request. Unsure if this "GET" condition is necessary but we should consider removing it in future
daibhin
commented
Oct 31, 2023
| # Throttle class that's very aggressive on a publicly accessible endpoint from the clients | ||
| # Intended to block sustained bursts of requests, per team | ||
| scope = "public_upload" | ||
| rate = "6/hour" |
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
To support the In-App Video Recording hackathon in Bologna we needed a way to allow attachments to be uploaded publicly.
We have no intention of merging this but leaving it here for the future traveller who might want to explore the approach in future. I will leave comments to discuss some difficulties / considerations faced along the way
Changes
UploadedMediaobject under the hoodNot considered
How did you test this code?
Some minor tests but would need a lot more