Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Producer refactor #27672

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

feat: Producer refactor #27672

wants to merge 10 commits into from
+956 −6,287

Conversation

benjackwhite
Copy link
Contributor

@benjackwhite benjackwhite commented Jan 19, 2025 •
edited
Loading

Problem

Same as #27153 just without changes to the runner

Changes

  • Added some new config options and made it so that every config can specify a target (consumer vs producer)
  • Didn't do this for kafkajs as that is only used by consumers anyways (the default value)
  • Refactored the producer code so that it is all in one place and uses the helper class
  • Removed the waitForAck stuff - we only don't wait in a couple of places and they should be done with handlign the promise async instead.

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@benjackwhite benjackwhite marked this pull request as ready for review January 19, 2025 10:58
@benjackwhite benjackwhite requested a review from a team January 19, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@benjackwhite