fix: clarify PGRST116 error message #3795
Open
+23
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is this really a fix? I don't think so, nothing is broken. I wouldn't backport it. Imho it's just "changed". In conventional commits, this would still be a "feat", I think? Not sure. I guess I don't like strict conventional commits... |
Currently it's redundant and not easy to read.
```
{"message":"JSON object requested, multiple (or no) rows returned",
"details":"The result contains 2 rows"}
```
Now:
```
{"message":"Cannot coerce the result to a single JSON object",
"details":"The result contains an array of 0 objects"}
``
Also correct docs which had a wrong error code.
steve-chavez
force-pushed
the
pgrst116
branch
from
d667981
to
b4d28ef
Compare
|
Hm, I did a fix commit on da1150d, which was about changing messages too.
I do think it's a "fix" (fixes error message redundancy), but not so critical to backport it. Definitely not a feature though, I would want to keep those clearly differentiated in commits and CHANGELOG entries because they correlate to breaking changes sometimes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it's redundant.
{"message":"JSON object requested, multiple (or no) rows returned", "details":"The result contains 0 rows"}Now:
{"message":"Cannot coerce the result to a single JSON object", "details":"The result contains 0 rows"}Also correct docs which had a wrong error code.