Do not access an uint32_t directly, it might be unaligned

PowerDNS · Nov 19, 2024 · ea9d3de · ea9d3de
1 parent 2011fbb
commit ea9d3de
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/pdns/recursordist/pdns_recursor.cc b/pdns/recursordist/pdns_recursor.cc
@@ -2036,7 +2036,9 @@ void getQNameAndSubnet(const std::string& question, DNSName* dnsname, uint16_t*
     pos += 1;
     const auto* drh = reinterpret_cast<const dnsrecordheader*>(&question.at(pos)); // NOLINT(cppcoreguidelines-pro-type-reinterpret-cast)
     if (ntohs(drh->d_type) == QType::OPT) {
-      ednsVersion = drh->d_ttl;
+      uint32_t edns;
+      memcpy(&edns, &drh->d_ttl, sizeof(edns)); // dh is not neccesarily aligned, so no uint32 assignment
+      ednsVersion = edns;
     }
     pos += sizeof(dnsrecordheader);