Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth-4.9.x: Partial backport of #14057 #14058

Merged
merged 1 commit into from
May 14, 2024

Conversation

mind04
Copy link
Contributor

@mind04 mind04 commented Apr 10, 2024

Short description

Partial backport of #14057

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@Habbie Habbie added this to the auth-4.9.x milestone Apr 11, 2024
@Habbie
Copy link
Member

Habbie commented Apr 11, 2024

build failure is unrelated

@Habbie Habbie closed this May 13, 2024
@Habbie Habbie reopened this May 13, 2024
@coveralls
Copy link

coveralls commented May 13, 2024

Pull Request Test Coverage Report for Build 9064336257

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 10 (0.0%) changed or added relevant lines in 2 files are covered.
  • 26 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.06%) to 62.995%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/backends/gsql/gsqlbackend.cc 0 1 0.0%
pdns/auth-primarycommunicator.cc 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
pdns/ueberbackend.cc 1 80.36%
pdns/misc.cc 1 48.78%
pdns/packethandler.cc 4 72.47%
ext/lmdb-safe/lmdb-safe.hh 6 62.12%
modules/lmdbbackend/lmdbbackend.cc 14 72.5%
Totals Coverage Status
Change from base Build 8941417661: -0.06%
Covered Lines: 41616
Relevant Lines: 59289

💛 - Coveralls

@Habbie
Copy link
Member

Habbie commented May 13, 2024

rebased

@Habbie Habbie merged commit 44005ac into PowerDNS:rel/auth-4.9.x May 14, 2024
29 of 30 checks passed
@mind04 mind04 deleted the auth-4.9.x-bp-14057 branch May 14, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants