Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth: added a new config for direct queries of dnskey signature #14581

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

d-wibowo
Copy link
Contributor

Short description

Addresses the feature request that I made on Issue #14372.

Added a new setting called direct-dnskey-signature, which allows for the direct retrieval of DNSKEY signature from the backend.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@coveralls
Copy link

coveralls commented Aug 23, 2024

Pull Request Test Coverage Report for Build 10521093224

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • 6362 unchanged lines in 125 files lost coverage.
  • Overall coverage increased (+5.7%) to 64.677%

Files with Coverage Reduction New Missed Lines %
pdns/dnspacket.hh 1 94.44%
pdns/auth-catalogzone.hh 1 66.67%
pdns/uuid-utils.cc 1 42.86%
pdns/protozero.cc 1 40.0%
pdns/libssl.hh 1 0.0%
pdns/recursordist/nod.hh 1 92.59%
modules/remotebackend/zmqconnector.cc 2 68.55%
pdns/epollmplexer.cc 2 83.75%
pdns/recursordist/rec-tcp.cc 2 65.5%
pdns/snmp-agent.hh 2 75.0%
Totals Coverage Status
Change from base Build 10516284382: 5.7%
Covered Lines: 124618
Relevant Lines: 162022

💛 - Coveralls

@Habbie Habbie added this to the auth-5 milestone Aug 26, 2024
@Habbie Habbie self-requested a review August 26, 2024 11:39
@d-wibowo
Copy link
Contributor Author

Hi @Habbie, any plans to review this soon?

@d-wibowo
Copy link
Contributor Author

Hi @Habbie , are there any news on this PR? Do you have any plans or schedules yet?

@Habbie
Copy link
Member

Habbie commented Oct 21, 2024

Can't promise anything but I really do hope to get to it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants