-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auth: don't build .so for non-dyn modules #14676
base: master
Are you sure you want to change the base?
Conversation
I am not sure we need the dependency LD flags on the static version. On the other hand, having them might allow us to use libtool to find our statically linkable modules during the build without the OBJECTFILES/OBJECTLIBS hack - but as we hope to just switch to Meson soon, I'm not going to put more effort in. |
markes as draft because I want to test package builds (once this PR itself turns green) |
Pull Request Test Coverage Report for Build 10901395890Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
packages look unchanged, and work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and I hope meson is around the corner 🚀
Short description
fixes #14027
Checklist
I have: