Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth: don't build .so for non-dyn modules #14676

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Habbie
Copy link
Member

@Habbie Habbie commented Sep 17, 2024

Short description

fixes #14027

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@Habbie
Copy link
Member Author

Habbie commented Sep 17, 2024

I am not sure we need the dependency LD flags on the static version. On the other hand, having them might allow us to use libtool to find our statically linkable modules during the build without the OBJECTFILES/OBJECTLIBS hack - but as we hope to just switch to Meson soon, I'm not going to put more effort in.

@Habbie Habbie marked this pull request as draft September 17, 2024 10:41
@Habbie
Copy link
Member Author

Habbie commented Sep 17, 2024

markes as draft because I want to test package builds (once this PR itself turns green)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10901395890

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 93 unchanged lines in 14 files lost coverage.
  • Overall coverage decreased (-0.002%) to 64.705%

Files with Coverage Reduction New Missed Lines %
modules/gpgsqlbackend/gpgsqlbackend.cc 1 88.62%
pdns/misc.cc 1 63.83%
pdns/validate.cc 1 68.09%
pdns/recursordist/aggressive_nsec.cc 2 66.1%
pdns/distributor.hh 2 51.86%
modules/lmdbbackend/lmdbbackend.cc 2 73.5%
pdns/recursordist/recpacketcache.hh 3 89.55%
modules/gpgsqlbackend/spgsql.cc 3 67.46%
pdns/dnsdistdist/dnsdist-carbon.cc 6 62.43%
pdns/packethandler.cc 8 72.74%
Totals Coverage Status
Change from base Build 10882883877: -0.002%
Covered Lines: 124869
Relevant Lines: 162272

💛 - Coveralls

@Habbie
Copy link
Member Author

Habbie commented Sep 19, 2024

markes as draft because I want to test package builds (once this PR itself turns green)

https://github.com/Habbie/pdns/actions/runs/10939385287

@Habbie
Copy link
Member Author

Habbie commented Sep 19, 2024

packages look unchanged, and work

@Habbie Habbie marked this pull request as ready for review September 19, 2024 12:05
@Habbie Habbie added this to the auth-5 milestone Sep 19, 2024
Copy link
Collaborator

@zeha zeha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and I hope meson is around the corner 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pdns-server: double free crash with --version
3 participants