Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Add meson support #14724

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

dnsdist: Add meson support #14724

wants to merge 17 commits into from

Conversation

rgacogne
Copy link
Member

Short description

This PR is unfortunately duplicating quite a lot of sub-directories from the root meson directory used by the auth and rec, because we are either using them in a different way or the description is not accurate for dnsdist. It might make sense to use symlinks for the directories we are not modifying?

Closes #14654

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@coveralls
Copy link

coveralls commented Sep 27, 2024

Pull Request Test Coverage Report for Build 11405281222

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 298 of 462 (64.5%) changed or added relevant lines in 24 files are covered.
  • 9901 unchanged lines in 132 files lost coverage.
  • Overall coverage decreased (-2.0%) to 62.668%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/dnsdistdist/bpf-filter.cc 0 1 0.0%
pdns/dnsdistdist/dnsdist-tcp-upstream.hh 0 1 0.0%
pdns/dnsdistdist/test-dnsdist-lua-ffi.cc 0 1 0.0%
pdns/dnsdistdist/dnsdist-kvs.hh 0 2 0.0%
pdns/dnsdistdist/dnsdist-nghttp2-in.cc 15 17 88.24%
pdns/dnsdistdist/dnsdist-lbpolicies.cc 0 3 0.0%
pdns/dnsdistdist/dnsdist-lua-ffi.cc 0 3 0.0%
pdns/dnsdistdist/dnsdist-nghttp2.cc 11 14 78.57%
pdns/dnsdistdist/test-dnsdistnghttp2_common.hh 9 12 75.0%
pdns/tcpiohandler.cc 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
pdns/webserver.hh 1 66.33%
pdns/dnsdistdist/test-dnsdistlbpolicies_cc.cc 1 79.09%
pdns/dnsdistdist/test-dnsdistnghttp2_common.hh 2 73.45%
pdns/ws-api.cc 2 84.91%
ext/yahttp/yahttp/utility.hpp 2 36.53%
pdns/burtle.hh 2 97.55%
pdns/lock.hh 2 84.52%
pdns/dnsdistdist/dnsdist-lua-bindings-dnsquestion.cc 2 0.0%
pdns/channel.hh 2 45.89%
pdns/dnsdistdist/test-dnsdistnghttp2-in_cc.cc 2 83.42%
Totals Coverage Status
Change from base Build 11402945382: -2.0%
Covered Lines: 104352
Relevant Lines: 144412

💛 - Coveralls

@omoerbeek
Copy link
Member

omoerbeek commented Sep 27, 2024

I tested macOS (dnsdist + testrunner, no further options), no changes needed.

This patch makes basic build of dnsdist + testrunner succeed on OpenBSD:
x.txt

@rgacogne
Copy link
Member Author

Applied, thanks!

@chbruyand chbruyand self-requested a review September 30, 2024 12:57
@@ -29,19 +29,19 @@
#include "dnsparser.hh"

// NOLINTNEXTLINE(readability-function-cognitive-complexity): this function declares Lua bindings, even with a good refactoring it will likely blow up the threshold
void setupLuaBindingsDNSQuestion(LuaContext& luaCtx)
void setupLuaBindingsDNSQuestion([[maybe_unused]] LuaContext& luaCtx)

Check warning

Code scanning / CodeQL

Poorly documented large function Warning

Poorly documented function: fewer than 2% comments for a function of 568 lines.
@rgacogne rgacogne marked this pull request as ready for review October 22, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dnsdist: Move the build system to meson
3 participants