-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dnsdist: Add meson support #14724
base: master
Are you sure you want to change the base?
dnsdist: Add meson support #14724
Conversation
Pull Request Test Coverage Report for Build 11405281222Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
I tested macOS (dnsdist + testrunner, no further options), no changes needed. This patch makes basic build of dnsdist + testrunner succeed on OpenBSD: |
Applied, thanks! |
2fc3876
to
7a57f5e
Compare
@@ -29,19 +29,19 @@ | |||
#include "dnsparser.hh" | |||
|
|||
// NOLINTNEXTLINE(readability-function-cognitive-complexity): this function declares Lua bindings, even with a good refactoring it will likely blow up the threshold | |||
void setupLuaBindingsDNSQuestion(LuaContext& luaCtx) | |||
void setupLuaBindingsDNSQuestion([[maybe_unused]] LuaContext& luaCtx) |
Check warning
Code scanning / CodeQL
Poorly documented large function Warning
The `#if` should be `#ifdef` or `#if defined`, as otherwise it fails with the `config.h` generated by `meson`.
Short description
This PR is unfortunately duplicating quite a lot of sub-directories from the root
meson
directory used by the auth and rec, because we are either using them in a different way or the description is not accurate for dnsdist. It might make sense to use symlinks for the directories we are not modifying?Closes #14654
Checklist
I have: