Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdns: use std::variant #14727

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

pdns: use std::variant #14727

wants to merge 1 commit into from

Conversation

neheb
Copy link
Contributor

@neheb neheb commented Sep 28, 2024

Gets further away from boost.

I have:

Gets further away from boost.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11086341914

Details

  • 2 of 99 (2.02%) changed or added relevant lines in 4 files are covered.
  • 5747 unchanged lines in 75 files lost coverage.
  • Overall coverage decreased (-3.6%) to 61.085%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/lua-auth4.cc 0 4 0.0%
pdns/lua-base4.cc 2 19 10.53%
pdns/lua-record.cc 0 33 0.0%
modules/lua2backend/lua2api2.hh 0 43 0.0%
Files with Coverage Reduction New Missed Lines %
pdns/webserver.hh 1 69.16%
pdns/dnsdistdist/dnsdist-crypto.cc 1 76.01%
pdns/recursordist/ext/protozero/include/protozero/config.hpp 1 0.0%
pdns/recursordist/sortlist.hh 1 75.0%
pdns/iputils.hh 1 76.56%
pdns/dnstap.cc 2 68.82%
ext/probds/murmur3.cc 2 88.24%
pdns/dnsname.hh 2 91.36%
modules/gsqlite3backend/gsqlite3backend.cc 2 94.44%
pdns/recursordist/secpoll-recursor.cc 2 50.0%
Totals Coverage Status
Change from base Build 11066510928: -3.6%
Covered Lines: 118987
Relevant Lines: 162138

💛 - Coveralls

Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will have to also teach LuaWrapper how to handle std::variant for this to fly, as for now it only handles boost::variant.

@neheb
Copy link
Contributor Author

neheb commented Sep 30, 2024

is that the reason for the failures?

@rgacogne
Copy link
Member

rgacogne commented Oct 1, 2024

is that the reason for the failures?

For at least some of them, yes:

Trying to cast a lua variable from "table" to "St6vectorISt4pairIiS_IS0_INSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESt7variantIJbi7DNSNameS6_5QTypeEEESaISB_EEESaISE_EE"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants