Fix for 360 rotations at extreme values #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Ho <git@hogt.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the "360" move when a camera calculates the transition from an extremely low value to a high one (e.g. yaw=20 -> yaw=340).
Essentially just checks if the yaw destination rotation is >180 degrees, and if so, normalizes the usual yaw angle range (0,360) to a range in (-180,180) so that transitions between 360->0 don't go the other (long) way around, and rather goes through 0 smoothly. This does mean that points that change the yaw >180 degrees will now need an additional point somewhere in between.