-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect empty V2 server responses at ServerApiCall level instead of ResponseUtil level #1358
Merged
anamnavi
merged 27 commits into
PowerShell:master
from
anamnavi:fix-v2server-emptyresponses-errorhandling
Aug 14, 2023
Merged
Detect empty V2 server responses at ServerApiCall level instead of ResponseUtil level #1358
anamnavi
merged 27 commits into
PowerShell:master
from
anamnavi:fix-v2server-emptyresponses-errorhandling
Aug 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of ReponseUtil level
…to fix-v2server-emptyresponses-errorhandling
SydneyhSmith
added
PR-Bug
This pull request resolves an issue bug
Release
This pull request is part the next release
labels
Aug 14, 2023
alerickson
approved these changes
Aug 14, 2023
Co-authored-by: alerickson <25858831+alerickson@users.noreply.github.com>
Co-authored-by: alerickson <25858831+alerickson@users.noreply.github.com>
Co-authored-by: alerickson <25858831+alerickson@users.noreply.github.com>
Co-authored-by: alerickson <25858831+alerickson@users.noreply.github.com>
Co-authored-by: alerickson <25858831+alerickson@users.noreply.github.com>
Co-authored-by: alerickson <25858831+alerickson@users.noreply.github.com>
Co-authored-by: alerickson <25858831+alerickson@users.noreply.github.com>
Co-authored-by: alerickson <25858831+alerickson@users.noreply.github.com>
…to fix-v2server-emptyresponses-errorhandling
…ithub.com/anamnavi/PowerShellGet into fix-v2server-emptyresponses-errorhandling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously for scenarios where a package could not be found on the server, V2ServerApiCall responses returned were non-empty XML responses, so an error indicating package not found was not detected and errRecord was not populated. This meant that at the ResponseUtil level the response would try to be converted to a PSResourceInfo and throw an error and we would catch and error handle in FindHelper for the "Package not found" scenario.
This PR changes that. The parameter
$inlinecount=allpages
is added to the V2 request so thatcount
is always returned in the response. This is used to detect a "Package not found" scenario and then an errRecord with FullyQualifiedErrorId "PackageNotFound" is returned and detected in FindHelper to properly error write or write verbose.Changes were also made to the other ServerApiCalls classes to consistently return errRecords with FullyQualifiedErrorId "PackageNotFound" when a package isn't found.
PR Summary
PR Context
Resolves #1349
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.