Bugfix - Correctly match package names from local repos #1663
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
There was a bug in how we parse out name and version information from package file names when performing search against local repositories.
If you have a package
test
and test.submodule` present in the local repository their files will look like this:We used WildCardPattern class before, with pattern
{packageName}.*" which would pick up both packages if package
testwas searched for. The code logic then assumed the rest of the part of the name would be the version so it would search through both package names and try to parse
submodule.1.0.0` into a version.This fix uses Regex more accurately created for the package name and to expect a version right after the name, not text.
PR Context
Fixes #1641 #1648
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.