Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix - Correctly match package names from local repos #1663

Closed

Conversation

anamnavi
Copy link
Member

@anamnavi anamnavi commented Jun 11, 2024

PR Summary

There was a bug in how we parse out name and version information from package file names when performing search against local repositories.

If you have a package test and test.submodule` present in the local repository their files will look like this:

`test.1.0.0.nupkg`
`test.submodule.1.0.0.nupkg`

We used WildCardPattern class before, with pattern {packageName}.*" which would pick up both packages if package testwas searched for. The code logic then assumed the rest of the part of the name would be the version so it would search through both package names and try to parsesubmodule.1.0.0` into a version.

This fix uses Regex more accurately created for the package name and to expect a version right after the name, not text.

PR Context

Fixes #1641 #1648

PR Checklist

@anamnavi anamnavi changed the title Bugfix - Correctly match package names from local repos against name and version criteria Bugfix - Correctly match package names from local repos Jun 17, 2024
@anamnavi anamnavi closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error parsing version from package name for filesystem-based repository
1 participant