Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glowup: prefect-server chart #213

Merged
merged 25 commits into from
Jul 27, 2023
Merged

glowup: prefect-server chart #213

merged 25 commits into from
Jul 27, 2023

Conversation

jamiezieziula
Copy link
Contributor

@jamiezieziula jamiezieziula commented Jul 27, 2023

Resolves #187
Resolves #107
Resolves #199 - Thanks to @MrCoffey for the research & documentation contribution!

Default postgresql password & API URL

jamiedick in ~/src/prefecthq/prefect-helm/charts/prefect-server on server-work λ helm install server .
NAME: server
LAST DEPLOYED: Wed Jul 26 22:15:07 2023
NAMESPACE: prefect
STATUS: deployed
REVISION: 2
TEST SUITE: None
NOTES:
Run the following command to port-forward the UI to your localhost:
$ kubectl --namespace jamie-helm-test port-forward svc/prefect-server 4200:4200

Visit http://localhost:4200 to use Prefect!
jamiedick in ~/src/prefecthq/prefect-helm/charts/prefect-server on server-work λ kubectl port-forward svc/prefect-server 4200:4200
Forwarding from 127.0.0.1:4200 -> 4200
Forwarding from [::1]:4200 -> 4200
Screenshot 2023-07-26 at 10 14 45 PM

Also tested with an existing secret and everything looks good

# -- sets PREFECT_UI_API_URL; should be publicly accessible API URL; UI will not work unless set
publicApiUrl: ""
# -- sets PREFECT_UI_API_URL; should be publicly accessible API URL
publicApiUrl: http://localhost:4200/api
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

providing a default value to for the UI url for ease of new users

# -- password for the custom user to create. Ignored if `auth.existingSecret` with key `password` is provided
password: ""
# -- password for the custom user. Ignored if `auth.existingSecret` with key `password` is provided
password: "prefect-rocks"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

providing a default password so that chart install doesnt fail if the user doesn't make any changes

@jamiezieziula jamiezieziula marked this pull request as ready for review July 27, 2023 02:25
@jamiezieziula jamiezieziula requested review from gabcoyne and a team as code owners July 27, 2023 02:25
@jamiezieziula jamiezieziula added the enhancement An improvement of an existing feature label Jul 27, 2023

Without making any modifications to the `values.yaml` file, you can access the Prefect UI by port forwarding either the Server `pod` or `service` with the following command and visiting [http:localhost:4200](http:localhost:4200):
```console
kubectl port-forward svc/prefect-server 4200:4200
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, i didn't know you could port-forward to a service. TIL

parkedwards
parkedwards previously approved these changes Jul 27, 2023
Copy link
Contributor

@parkedwards parkedwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome

Co-authored-by: Edward Park <ed.sh.park@gmail.com>
Copy link
Contributor

@jimid27 jimid27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is spectacular

@jamiezieziula jamiezieziula merged commit 95daac1 into main Jul 27, 2023
3 checks passed
@jamiezieziula jamiezieziula deleted the server-work branch July 27, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs enhancement An improvement of an existing feature
Projects
None yet
3 participants