Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed minor issue in optimizing BPR objective of MTER and ComparER_sub #514

Closed
wants to merge 1 commit into from

Conversation

lthoang
Copy link
Member

@lthoang lthoang commented Jun 25, 2023

Description

user_ids[i_idx] may not be identical to u_idx [WRONG].
user_ids[i_idx] should be user_ids[idx], which is identical as u_idx [CORRECT].

Related Issues

Checklist:

  • I have added tests.
  • I have updated the documentation accordingly.
  • I have updated README.md (if you are adding a new model).
  • I have updated examples/README.md (if you are adding a new example).
  • I have updated datasets/README.md (if you are adding a new dataset).

@tqtg
Copy link
Member

tqtg commented Jun 25, 2023

A good practice is to fork a new repo, then make changes and create a PR from the forked one. Let's do that before we revise the logic.

@lthoang lthoang closed this Jun 26, 2023
@tqtg tqtg deleted the mter branch June 26, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants