Add rank function for ComparER_sub and fix getting wrong uid in BPR negative sampling for ComparER_sub and MTER #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lthoang
changed the title
tqtg
approved these changes
Jun 26, 2023
|
LGTM. Please feel free to merge |
lthoang
changed the title
lthoang
changed the title
lthoang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding rank function that incorporates top aspect score as described in the paper.
Fixing minor issue of getting wrong user id in BPR negative sampling.
user_ids[i_idx]may not be identical tou_idx[WRONG].user_ids[i_idx]should beuser_ids[idx], which is identical asu_idx[CORRECT].Related Issues
Checklist:
README.md(if you are adding a new model).examples/README.md(if you are adding a new example).datasets/README.md(if you are adding a new dataset).