Fix .rank() method for multiple models #615
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new
Recommender.rank()
function addsk
as required value, which breaks some models that do not usek
in ranking evaluation (e.g., ComparER, EFM, LRPPM).I putk
into**kwargs
and usek = kwargs.get("k", -1)
instead.Another option is to addk=None
to incompatible models.I added and updated topK ranking for mentioned models.