Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EFM train_set fitting #27

Merged
merged 2 commits into from
May 18, 2024
Merged

Conversation

hieuddo
Copy link
Member

@hieuddo hieuddo commented May 7, 2024

Fix RecSys notebook 7 as discussed here.

There are some output differences, which I think is because of some changes from cornac that exclude positive training items from testing.

@hieuddo hieuddo added the bug Something isn't working label May 7, 2024
@hieuddo hieuddo requested review from lthoang and tqtg May 7, 2024 09:24
@tqtg
Copy link
Member

tqtg commented May 7, 2024

@lthoang please have a look and see if the output is as intended. Thanks

Copy link
Member

@lthoang lthoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hieuddo As we discussed, the output looks fine to me.
In addition, could you please increase the num_top_opinions to 4 or 5 to reflect the differences between the explanations on different aspects of MTER model.

@hieuddo
Copy link
Member Author

hieuddo commented May 8, 2024

I changed num_top_opinions to 4 and kept num_top_aspects at 2 to make it diverse. If we increase they would be identical.

image

@hieuddo hieuddo merged commit 048728f into PreferredAI:master May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants