Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added template specializations for acoustic and elastic kernels class #291

Merged
merged 5 commits into from
Dec 13, 2024
Merged

Added template specializations for acoustic and elastic kernels class #291

merged 5 commits into from
Dec 13, 2024

Conversation

Rohit-Kakodkar
Copy link
Collaborator

Description

Implements #276

Issue Number

Closes #276

Checklist

Please make sure to check developer documentation on specfem docs.

  • I ran the code through pre-commit to check style
  • My code passes all the integration tests
  • I have added sufficient unittests to test my changes
  • I have added/updated documentation for the changes I am proposing
  • I have updated CMakeLists to ensure my code builds
  • My code builds across all platforms

@Rohit-Kakodkar Rohit-Kakodkar changed the title Issue 276 Added template specializations for acoustic and elastic kernels class Dec 12, 2024
lsawade
lsawade approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@lsawade lsawade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed during meeting

@Rohit-Kakodkar Rohit-Kakodkar merged commit 26df960 into issue-228-anisotropy Dec 13, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icui icui icui approved these changes

@lsawade lsawade lsawade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rohit-Kakodkar @lsawade @icui