Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password toggling functionality #528

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

UtkarshBirla28
Copy link
Contributor

@UtkarshBirla28 UtkarshBirla28 commented Jun 22, 2024

Solved issue number #375

Added password toggling functionality so that user can hide or view there password by clicking on the eye button according to there need.

This feature enhances flexibility for the user also when you hover on the icon it changes it's color to #007efc.

It is integrated using react-fontawesome library for eye icon and functionality by using little bit of logic.

Added password toggling functionality so that user can hide or view there password by clicking on the eye button according to there need.

This feature enhances flexibility for the user.
Copy link

netlify bot commented Jun 22, 2024

Deploy Preview for startconnect-hub ready!

Name Link
🔨 Latest commit 940ffbc
🔍 Latest deploy log https://app.netlify.com/sites/startconnect-hub/deploys/667691eea702ae000978f461
😎 Deploy Preview https://deploy-preview-528--startconnect-hub.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@UtkarshBirla28
Copy link
Contributor Author

@Priyaaa1 Check the PR please and notify me if any change is required.

@Priyaaa1
Copy link
Owner

Priyaaa1 commented Jun 22, 2024

@UtkarshBirla28 kindly mention your issue no. which you are resolving

@UtkarshBirla28
Copy link
Contributor Author

UtkarshBirla28 commented Jun 22, 2024

@UtkarshBirla28 kindly mention your issue no. which you are resolving
@Priyaaa1 Issue number is #375

@Priyaaa1
Copy link
Owner

@UtkarshBirla28 you mentioned the PR number, I need you to mention the issue number for which you raised this PR so that this PR merge will give you score.

@UtkarshBirla28
Copy link
Contributor Author

@UtkarshBirla28 you mentioned the PR number, I need you to mention the issue number for which you raised this PR so that this PR merge will give you score.

issue number is #375

@Priyaaa1
Copy link
Owner

image

It is showing 2 icons for password toggling while entering the password. Kindly fix it.

@UtkarshBirla28
Copy link
Contributor Author

Ohh sorry i will look into it as soon as possible.

@UtkarshBirla28
Copy link
Contributor Author

UtkarshBirla28 commented Jun 23, 2024

Screenshot (81)

@Priyaaa1 Idk what's the problem but it is working perfectly fine on my system.

23.06.2024_19.08.38_REC.mp4

seee

@Priyaaa1 Priyaaa1 added enhancement New feature or request gssoc PR related to GSSoC'24 level1 labels Jun 24, 2024
@Priyaaa1 Priyaaa1 merged commit c3f20c2 into Priyaaa1:main Jun 24, 2024
4 checks passed
Copy link

Congratulations, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to the project 🚀 Keep Contributing!! ✨

@UtkarshBirla28
Copy link
Contributor Author

@Priyaaa1 Thankyou!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc PR related to GSSoC'24 level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants