-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DeepEdit infer to accept clicks from viewer #491
Update DeepEdit infer to accept clicks from viewer #491
Conversation
Signed-off-by: Andres <diazandr3s@gmail.com>
for more information, see https://pre-commit.ci
Signed-off-by: Andres <diazandr3s@gmail.com>
HI @diazandr3s , thanks for the PR, let me also try this bundle in our MONAI Label with 3D Slicer and OHIF plugins. This bundle will be a big hit to many projects. Will comment, thank you. |
Hi @diazandr3s , Please also update the README to add the expected input data format if having clicks and the CLI command to run it. Thanks in advance. |
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Andres <diazandr3s@gmail.com>
Signed-off-by: Andres <diazandr3s@gmail.com>
for more information, see https://pre-commit.ci
Hi @diazandr3s @yiheng-wang-nv , Thanks for the quick update. Thanks. |
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Hi @diazandr3s @tangy5 , I pushed a new commit with unit test changes and readme updates, could you please help to double confirm it? Thanks! |
Hi @yiheng-wang-nv, Thanks for the update! It is working on my end. Thanks again! |
Hi All, one more thing to think about here, if a foreground click is not associate with any organ, how can we handle the click. We will need a logic to define coordinate alone. how about: |
Good point! |
Hi @tangy5 , I think for this bundle, as @diazandr3s said, since |
/build |
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
/build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now.
@yiheng-wang-nv Do you have any other comments?
If not, let's merge it.
Thanks.
Update DeepEdit Infer config to accept clicks from the user --------- Signed-off-by: Andres <diazandr3s@gmail.com> Signed-off-by: Yiheng Wang <vennw@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Yiheng Wang <vennw@nvidia.com>
Update DeepEdit Infer config to accept clicks from the user