Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsupported data dtype for FindContours in vista2d #678

Merged
merged 4 commits into from
Sep 29, 2024

Conversation

KumoLiu
Copy link
Collaborator

@KumoLiu KumoLiu commented Sep 27, 2024

Fixes #677

Description

Use cv2.convertScaleAbs function to scale and convert the label to an 8-bit format then apply find_contours, it will not influence the result of the contours.

Status

Ready/Work in progress/Hold

Please ensure all the checkboxes:

  • Codeformat tests passed locally by running ./runtests.sh --codeformat.
  • In-line docstrings updated.
  • Update version and changelog in metadata.json if changing an existing bundle.
  • Please ensure the naming rules in config files meet our requirements (please refer to: CONTRIBUTING.md).
  • Ensure versions of packages such as monai, pytorch and numpy are correct in metadata.json.
  • Descriptions should be consistent with the content, such as eval_metrics of the provided weights and TorchScript modules.
  • Files larger than 25MB are excluded and replaced by providing download links in large_file.yml.
  • Avoid using path that contains personal information within config files (such as use /home/your_name/ for "bundle_root").

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
KumoLiu and others added 3 commits September 27, 2024 16:53
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@yiheng-wang-nv
Copy link
Collaborator

/build

@KumoLiu
Copy link
Collaborator Author

KumoLiu commented Sep 29, 2024

Hi @yiheng-wang-nv, let's wait for @SachidanandAlle and @myron's review to merge this PR, thanks!

@KumoLiu KumoLiu merged commit 85df47e into Project-MONAI:dev Sep 29, 2024
4 checks passed
@KumoLiu KumoLiu deleted the fix-vista2d branch September 29, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsupported data dtype for FindContours in vista2d
3 participants