Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added comment with script for installing library #437

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Business-Wizard
Copy link

No description provided.

@denised
Copy link
Member

denised commented Sep 11, 2021

@Business-Wizard which tests show an error, and what platform are you running them on?
And what is the purpose of the comment for fair?

@Business-Wizard
Copy link
Author

While setting up my env to get started adding value, I realized not all of the libraries installed properly. It seems fair is not on the conda-forge repository, so I did the research and found the needed script to install it for new users. 😊

@Business-Wizard
Copy link
Author

Running tests on an Ubuntu 20.04.
Haven't figured out how to get the yaml library working for the tests yet - that is the only remaining 8 tests throwing errors.

@denised
Copy link
Member

denised commented Sep 11, 2021

OK. Requirements.txt is meant to be used with pip, which does know how to install fair. (And we use pip in to install fair in the conda file environment.yml as well.) So I think we're covered on that one.

@Business-Wizard
Copy link
Author

Ah, neat - I'll spend some time figuring how to properly use the environment file later and see if that doesn't just fix it.
Hope it resolved the yaml errors too, and I can remove this PR. 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants