enhancement/issue 1220 adopt NodeJS register API for custom loaders (#…

…1373)
ProjectEvergreen · Jan 12, 2025 · 33da5e2 · 33da5e2
1 parent 287b993
commit 33da5e2
Show file tree

Hide file tree

Showing 8 changed files with 21 additions and 10 deletions.
diff --git a/.github/workflows/ci-loaders.yml b/.github/workflows/ci-loaders.yml
@@ -12,12 +12,12 @@ jobs:
         node: [20, 22]
 
     steps:
-    - uses: actions/checkout@v1
+    - uses: actions/checkout@v4
     - name: Install Chromium Library Dependencies
       run: |
         sh ./.github/workflows/chromium-lib-install.sh
     - name: Use Node.js ${{ matrix.node }}
-      uses: actions/setup-node@v3
+      uses: actions/setup-node@v4
       with:
         node-version: ${{ matrix.node }}
     - name: Installing project dependencies

diff --git a/.github/workflows/ci-win-loaders.yml b/.github/workflows/ci-win-loaders.yml
@@ -12,9 +12,9 @@ jobs:
         node: [20]
 
     steps:
-    - uses: actions/checkout@v1
+    - uses: actions/checkout@v4
     - name: Use Node.js ${{ matrix.node }}
-      uses: actions/setup-node@v3
+      uses: actions/setup-node@v4
       with:
         node-version: ${{ matrix.node }}
     - name: Installing project dependencies

diff --git a/.github/workflows/ci-win.yml b/.github/workflows/ci-win.yml
@@ -12,9 +12,9 @@ jobs:
         node: [20]
 
     steps:
-    - uses: actions/checkout@v1
+    - uses: actions/checkout@v4
     - name: Use Node.js ${{ matrix.node }}
-      uses: actions/setup-node@v3
+      uses: actions/setup-node@v4
       with:
         node-version: ${{ matrix.node }}
     - name: Installing project dependencies

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -12,12 +12,12 @@ jobs:
         node: [20, 22]
 
     steps:
-    - uses: actions/checkout@v1
+    - uses: actions/checkout@v4
     - name: Install Chromium Library Dependencies
       run: |
         sh ./.github/workflows/chromium-lib-install.sh
     - name: Use Node.js ${{ matrix.node }}
-      uses: actions/setup-node@v3
+      uses: actions/setup-node@v4
       with:
         node-version: ${{ matrix.node }}
     - name: Installing project dependencies

diff --git a/package.json b/package.json
@@ -21,8 +21,8 @@
     "serve": "node . serve",
     "develop": "node . develop",
     "test": "cross-env BROWSERSLIST_IGNORE_OLD_DATA=true __GWD_ROLLUP_MODE__=strict NODE_NO_WARNINGS=1 c8 mocha --exclude \"./packages/**/test/cases/loaders-*/**\" \"./packages/**/**/*.spec.js\"",
-    "test:loaders": "cross-env BROWSERSLIST_IGNORE_OLD_DATA=true __GWD_ROLLUP_MODE__=strict NODE_NO_WARNINGS=1 node --loader $(pwd)/test/test-loader.js ./node_modules/mocha/bin/mocha \"./packages/**/**/*.spec.js\"",
-    "test:loaders:win": "cross-env BROWSERSLIST_IGNORE_OLD_DATA=true __GWD_ROLLUP_MODE__=strict NODE_NO_WARNINGS=1 node --loader file:\\\\%cd%\\test\\test-loader.js ./node_modules/mocha/bin/mocha --exclude \"./packages/init/test/cases/**\" \"./packages/**/**/*.spec.js\"",
+    "test:loaders": "cross-env BROWSERSLIST_IGNORE_OLD_DATA=true __GWD_ROLLUP_MODE__=strict NODE_NO_WARNINGS=1 node --import $(pwd)/test/test-register.js ./node_modules/mocha/bin/mocha \"./packages/**/**/*.spec.js\"",
+    "test:loaders:win": "cross-env BROWSERSLIST_IGNORE_OLD_DATA=true __GWD_ROLLUP_MODE__=strict NODE_NO_WARNINGS=1 node --import file:\\\\%cd%\\test\\test-register.js ./node_modules/mocha/bin/mocha --exclude \"./packages/init/test/cases/**\" \"./packages/**/**/*.spec.js\"",
     "test:tdd": "yarn test --watch",
     "lint:js": "eslint \"*.js\" \"./packages/**/**/*.js\" \"./test/*.js\" \"./www/**/**/*.js\"",
     "lint:ts": "eslint \"./packages/**/**/*.ts\"",

diff --git a/packages/cli/package.json b/packages/cli/package.json
@@ -23,6 +23,11 @@
     "node": "^18.20.5 || ^20.10.0 || ^22.12.0"
   },
   "main": "./src/index.js",
+  "exports": {
+    ".": "./src/index.js",
+    "./register": "./src/register.js",
+    "./src/*": "./src/*"
+  },
   "bin": {
     "greenwood": "./src/index.js"
   },

diff --git a/packages/cli/src/register.js b/packages/cli/src/register.js
@@ -0,0 +1,3 @@
+import { register } from 'node:module';
+
+register('./loader.js', import.meta.url);
diff --git a/test/test-register.js b/test/test-register.js
@@ -0,0 +1,3 @@
+import { register } from 'node:module';
+
+register('./test-loader.js', import.meta.url);
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		import { register } from 'node:module';

		register('./loader.js', import.meta.url);
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		import { register } from 'node:module';

		register('./test-loader.js', import.meta.url);