Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/issue 1319 expand support for custom resource plugins like in frontmatter imports #1331

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Nov 30, 2024

Related Issue

resolves #1319

Summary of Changes

  1. Extend layout utilities to account for custom formats inside frontmatter imports
  2. Refined TypeScript to better support multiple use case (though a more thorough review should happen as part of leverage Sec-Fetch-Dest header for better filtering within Greenwood resource plugins #1222)
  3. Did some async refactoring to ensure predictable results (though a more thorough review should happen as part of make Greenwood CLI and plugins async through and through #823)
  4. Addressed an existing issue where custom CSS formats would not get properly bundled (could be its own issue, but seeing as it was directly in line of sight of this PR, just bundled it all up)
  5. Fixed an inconsistency where some resources were not getting optimized correctly
  6. Add test cases

Was thinking of backporting this to 0.30.x line, but due to the nature of these changes, will withhold this to the 0.31.x line

Documentation

N / A

TODO

  1. remove demo code

@thescientist13 thescientist13 added bug Something isn't working enhancement Improve something existing (e.g. no docs, new APIs, etc) Plugins Greenwood Plugins CLI labels Nov 30, 2024
@thescientist13 thescientist13 changed the title Bug/issue 1319 support custom resource plugin frontmatter imports bug/issue 1319 expend support for support custom resource plugins like in frontmatter imports Nov 30, 2024
@thescientist13 thescientist13 changed the title bug/issue 1319 expend support for support custom resource plugins like in frontmatter imports bug/issue 1319 expand support for support custom resource plugins like in frontmatter imports Nov 30, 2024
@thescientist13 thescientist13 changed the title bug/issue 1319 expand support for support custom resource plugins like in frontmatter imports bug/issue 1319 expand support for custom resource plugins like in frontmatter imports Dec 1, 2024
@thescientist13 thescientist13 force-pushed the bug/issue-1319-support-custom-resource-plugin-frontmatter-imports branch from 4ff91bd to d8ca368 Compare December 13, 2024 20:10
@thescientist13 thescientist13 merged commit 0e9c9b0 into master Dec 13, 2024
8 checks passed
@thescientist13 thescientist13 deleted the bug/issue-1319-support-custom-resource-plugin-frontmatter-imports branch December 13, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) Plugins Greenwood Plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

frontmatter imports not working for any format supported by a resource plugin
1 participant