Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement/issue 1343 unify around greenwood config based prerender behavior for renderer plugins #1344

Merged
merged 2 commits into from
Dec 22, 2024
Merged

enhancement/issue 1343 unify around greenwood config based prerender behavior for renderer plugins #1344

merged 2 commits into from
Dec 22, 2024

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Dec 13, 2024 •
edited
Loading

Related Issue

resolves #1343

Documentation

  1. clarify usage of prerender option in relation to Renderer plugins www.greenwoodjs.dev#149

Summary of Changes

  1. Standardize CLI <> Renderer Plugin relationship for prerender behavior
  2. Update relevant READMEs to reflect new requirement on prerender configuration
  3. Removed some latent console.log messages in the Lit SSR renderer

@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) documentation Greenwood specific docs Plugins Greenwood Plugins CLI Content as Data breaking SSR labels Dec 13, 2024
@thescientist13 thescientist13 changed the title enhancement/issue 1343 unify around greenwood config based prerender behavior enhancement/issue 1343 unify around greenwood config based prerender behavior for renderer plugins Dec 13, 2024
@thescientist13 thescientist13 force-pushed the enhancement/issue-1343-standardize-plugin-prerendering-against-greenwood-config branch from d65d570 to e5330fd Compare December 22, 2024 21:37
@thescientist13 thescientist13 merged commit f77b894 into master Dec 22, 2024
8 checks passed
@thescientist13 thescientist13 deleted the enhancement/issue-1343-standardize-plugin-prerendering-against-greenwood-config branch December 22, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking CLI Content as Data documentation Greenwood specific docs enhancement Improve something existing (e.g. no docs, new APIs, etc) Plugins Greenwood Plugins SSR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

standardize on Greenwood config as single source for prerender behavior for all renderer plugins
1 participant
@thescientist13