Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/issue 1346 bundle transitive CSS url(...) references #1348

Merged

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Dec 15, 2024

Related Issue

resolves #1346

Should now see a lot less Unable to resolve ... messages, as per AnalogStudiosRI/www.analogstudios.net#101

Documentation

  1. Will want to make sure any of these node_modules resolutions carry over to the CSS side as well - improve documentation around referencing scripts, styles, and import map diagnostics www.greenwoodjs.dev#144

Summary of Changes

  1. Leverage workingUrl to better handling bundling of relative url(...) references in CSS files
  2. Add test cases

TODO

  1. Are we properly handling all explicit case of ./. ../, and / (where / is not a reference to node_modules)

@thescientist13 thescientist13 added bug Something isn't working CLI labels Dec 15, 2024
@thescientist13 thescientist13 changed the title bug/issue 1346 bundle transient css url references bug/issue 1346 bundle transient CSS url(...) references Dec 15, 2024
@thescientist13 thescientist13 changed the title bug/issue 1346 bundle transient CSS url(...) references bug/issue 1346 bundle transitive CSS url(...) references Dec 19, 2024
@thescientist13 thescientist13 self-assigned this Dec 19, 2024
@thescientist13 thescientist13 force-pushed the bug/issue-1346-bundle-transient-CSS-url-references branch from 60d65dc to b57483c Compare December 28, 2024 00:46
@thescientist13 thescientist13 removed their assignment Dec 28, 2024
@thescientist13 thescientist13 merged commit 14de0b7 into master Dec 28, 2024
8 checks passed
@thescientist13 thescientist13 deleted the bug/issue-1346-bundle-transient-CSS-url-references branch December 28, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS bundling optimization not handling transitive relative url(...) references
1 participant