Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/issue 1352 align none optimization option with output filename and contents #1359

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Dec 24, 2024

Related Issue

resolves #1352

Documentation

N / A

Summary of Changes

  1. Have standard CSS plugin honor none optimization setting
  2. For CSS bundling, we still need to honor the contents of any plugin process
  3. For JavaScript / Rollup we don't want to emit the original source contents either
  4. In the standard HTML resource plugin, make sure "none" still pulls in the right final optimized contents
  5. Update test cases

TODO

  1. fix Windows build (probably a pathing issue in the test files)
  2. We should probably create a ticket for a completely unbundled output, that doesn't even transform filename. Basically whatever your src/ contents are, that is literally what will be moved over and better clarify difference / distinction between none and unbundled - support generating a completely unbundled project #1367

@thescientist13 thescientist13 added bug Something isn't working CLI labels Dec 24, 2024
@thescientist13 thescientist13 self-assigned this Dec 24, 2024
@thescientist13 thescientist13 added the question Further information is requested label Dec 24, 2024
@thescientist13 thescientist13 changed the title align none optimization option with output filename and contents bug/issue 1352 align none optimization option with output filename and contents Dec 24, 2024
@thescientist13 thescientist13 removed their assignment Dec 28, 2024
@thescientist13 thescientist13 force-pushed the bug/issue-1352-align-none-optimization-output-filename-and-contents-matching branch from a776684 to ef5a36a Compare December 28, 2024 01:34
@thescientist13 thescientist13 merged commit dee1bd4 into master Dec 28, 2024
8 checks passed
@thescientist13 thescientist13 deleted the bug/issue-1352-align-none-optimization-output-filename-and-contents-matching branch December 28, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLI question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

none optimization setting leads to broken resource requests in production builds
1 participant