Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement/issue 1202 bump to minimum supported NodeJS LTS versions #1372

Merged

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Dec 31, 2024

Related Issue

resolves #1202

Documentation

  1. Do we need to document minimum version in the website? - tracking here for now - docs/document new minimum NodeJS requirements for SSR custom loaders www.greenwoodjs.dev#159

Summary of Changes

  1. Bumped minimum NodeJS version to 18.20.5 (for unflagged JSON modules)
  2. Updated GitHub Actions to include runners for NodeJS 20.x / 22.x
  3. Updated project to use Node 20.x

See here for an analysis of current features - #1202 (comment)

As part of #1220 , we'll likely shift the GitHub Actions from [18, 20] -> [20, 22], but we can probably keep the minimum version of 18.20.5 in the engines field either way

TODO

  1. Should we actually set the engines to something like this, and maybe track stabilizing on one final >= version - stabilize to a single minumum NodeJS LTS version for engines #1379
    "engines": {
      "node": "^18.20.5 || ^20.10.0 || ^22.12.0"
    }
  2. Can probably close these out

@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) question Further information is requested CLI breaking labels Dec 31, 2024
@thescientist13 thescientist13 changed the title enhancement/bump to minimum NodeJS version of 18.20.5 enhancement/bump to minimum required NodeJS versions Jan 1, 2025
@thescientist13 thescientist13 force-pushed the enhancement/issue-1202-latest-nodejs-lts-engines branch from 33ddd9a to 639407e Compare January 11, 2025 18:30
@thescientist13 thescientist13 changed the title enhancement/bump to minimum required NodeJS versions enhancement/issue 1202 bump to minimum required NodeJS versions Jan 11, 2025
@thescientist13 thescientist13 changed the title enhancement/issue 1202 bump to minimum required NodeJS versions enhancement/issue 1202 bump to minimum required NodeJS LTS versions Jan 11, 2025
@thescientist13 thescientist13 changed the title enhancement/issue 1202 bump to minimum required NodeJS LTS versions enhancement/issue 1202 bump to minimum supported NodeJS LTS versions Jan 11, 2025
@thescientist13 thescientist13 added the chore unit testing, maintenance, etc label Jan 11, 2025
@thescientist13 thescientist13 merged commit 287b993 into master Jan 11, 2025
10 checks passed
@thescientist13 thescientist13 deleted the enhancement/issue-1202-latest-nodejs-lts-engines branch January 11, 2025 18:56
@thescientist13 thescientist13 added the documentation Greenwood specific docs label Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking chore unit testing, maintenance, etc CLI documentation Greenwood specific docs enhancement Improve something existing (e.g. no docs, new APIs, etc) question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Node 20.x (latest LTS)
1 participant