Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement/issue 684 import map generation cache and dedupe optimizations #1377

Merged
merged 3 commits into from
Jan 18, 2025
Merged

enhancement/issue 684 import map generation cache and dedupe optimizations #1377

merged 3 commits into from
Jan 18, 2025

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Jan 10, 2025 •
edited
Loading

Related Issue

related to #684

See this repo for reference - AnalogStudiosRI/api#44

Documentation

N / A

Summary of Changes

  1. Cache walked packages (helps mitigate cyclic / peer dependencies)
  2. Removed need for nested walkPackageJson within walkPackageJson
  3. Refactor import map to be an actual Map

TODO

  1. Why are some GraphQL tests failing, but only when run with the entire suite, not on their own individually 🤔
    • had to account for concurrency / worker thread pool scenaiors

@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) CLI alpha.4 v0.31.0 labels Jan 10, 2025
@thescientist13 thescientist13 self-assigned this Jan 10, 2025
@thescientist13 thescientist13 added this to the 1.0 milestone Jan 10, 2025
@thescientist13 thescientist13 changed the title enhancement/issue 684 import map generation dedupe optimizations enhancement/issue 684 import map generation cache and dedupe optimizations Jan 10, 2025
@thescientist13 thescientist13 marked this pull request as ready for review January 10, 2025 21:36
@thescientist13 thescientist13 mentioned this pull request Jan 10, 2025
Draft
18 tasks
@thescientist13 thescientist13 force-pushed the enhancement/issue-684-import-map-generation-dedupe-optimizations branch from c0ad9fa to ad7ac8e Compare January 13, 2025 17:27
@thescientist13 thescientist13 force-pushed the enhancement/issue-684-import-map-generation-dedupe-optimizations branch from ad7ac8e to 1cfab2e Compare January 18, 2025 02:05
@thescientist13 thescientist13 merged commit 2037d3b into master Jan 18, 2025
10 checks passed
@thescientist13 thescientist13 deleted the enhancement/issue-684-import-map-generation-dedupe-optimizations branch January 18, 2025 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thescientist13 thescientist13

Labels
alpha.5 CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) v0.31.0
Projects
[Greenwood] Phase 10 - Ecosystem Compat
Status: ✅ Done
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
1 participant
@thescientist13