Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds 'unsure' reasons buttons to new Validate beta #3605

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

misaugstad
Copy link
Member

@misaugstad misaugstad commented Jul 31, 2024

Resolves #3581

Adds buttons with 'Unsure' reasons to the new Validate page. We can and should iterate on the options that I've added in for now. The options came from Jon and I brainstorming, and looking through reasons that users have manually entered during previous Unsure validations. I'm starting with the following showing up for all label types:

  • Need a better image
    • This has an associated tooltip with the text: "This could be because the image is blurry, what's being labeled is too far away, or a different angle is needed"
  • Label placement looks incorrect

And then a third option for a few label types:

  • Curb Ramp: Alley or parking lot entrance
  • Missing Curb Ramp: Not sure if a curb ramp is required
  • Obstacle: Not sure if sidewalk is wide enough to avoid the obstacle
  • Surface Problem: Might be too minor to label
  • No Sidewalk: Not sure if there should be a sidewalk here
  • Crosswalk & Pedestrian Signal: None, I couldn't think of any good ones yet!
Before/After screenshots (if applicable)

Before
Screenshot from 2024-07-31 13-47-43

After:
Curb Ramp
Screenshot from 2024-07-31 13-40-15

Tooltip:
Screenshot from 2024-07-31 13-41-28

Missing Curb Ramp
Screenshot from 2024-07-31 13-41-19

Obstacle
Screenshot from 2024-07-31 13-41-39

Surface Problem
Screenshot from 2024-07-31 13-41-56

No Sidewalk
Screenshot from 2024-07-31 13-42-13

Crosswalk & Pedestrian Signal
Screenshot from 2024-07-31 13-39-47

Things to check before submitting the PR
  • I've written a descriptive PR title.
  • I've added/updated comments for large or confusing blocks of code.
  • I've included before/after screenshots above.
  • I've asked for and included translations for any user facing text that was added or modified.
  • I've updated any logging. Clicks, keyboard presses, and other user interactions should be logged. If you're not sure how (or if you need to update the logging), ask Mikey. Then make sure the documentation on this wiki page is up to date for the logs you added/updated.

@misaugstad misaugstad self-assigned this Jul 31, 2024
@misaugstad misaugstad merged commit 4c3e66d into develop Jul 31, 2024
@misaugstad misaugstad deleted the 3581-validate-beta-unsure-reasons branch July 31, 2024 20:59
@misaugstad misaugstad mentioned this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Validate should have default reasons for being unsure
1 participant