Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also load symbols in AssemblyResolve #251

Merged
merged 1 commit into from
Jan 4, 2025
Merged

Also load symbols in AssemblyResolve #251

merged 1 commit into from
Jan 4, 2025
+2 −1

Conversation

Arthri
Copy link
Contributor

@Arthri Arthri commented Jun 15, 2023

A prior PR already added PDB loading for plugins, and this PR extends that to any assemblies loaded in AssemblyResolve

@Arthri Arthri self-assigned this Jun 15, 2023
SignatureBeef
SignatureBeef approved these changes Jan 4, 2025
View reviewed changes
Copy link
Member

@SignatureBeef SignatureBeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, we do it for plugin loading so why not here too.
I'd be happy to merge as-is (so it can be included in upcoming changes), though usually id prefer to share the same code between the two though so whatever the other fellas prefer here.

@QuiCM QuiCM merged commit 596518e into Pryaxis:general-devel Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SignatureBeef SignatureBeef SignatureBeef approved these changes

Assignees

@Arthri Arthri

Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Arthri @SignatureBeef @QuiCM