Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move operation schema to HQAR repo #1

Merged
merged 12 commits into from
Mar 14, 2024
Merged

Move operation schema to HQAR repo #1

merged 12 commits into from
Mar 14, 2024

Conversation

dexter2206
Copy link
Contributor

No description provided.

@dexter2206 dexter2206 requested a review from mstechly March 11, 2024 15:45
mstechly
mstechly reviewed Mar 12, 2024
View reviewed changes
Copy link
Contributor

@mstechly mstechly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good.
However, I think we're missing a couple of things here (which might come in separate PRs):

  • README
  • A good explanation of how it is supposed to be used
  • Examples

src/hqar/_operation_v1.py Outdated Show resolved Hide resolved
@dexter2206 dexter2206 requested a review from mstechly March 13, 2024 16:49
@dexter2206 dexter2206 merged commit ac61687 into main Mar 14, 2024
5 checks passed
@dexter2206 dexter2206 deleted the 279-move-operation-schema-to-separate-repo branch March 14, 2024 20:04
mstechly pushed a commit that referenced this pull request Apr 24, 2024
@dexter2206 @mstechly
Move operation schema to QREF repo (#1)
057b8fb 
* Add basic pyproject.toml using Poetry

* Add linters/formatters/static anaylysis tools to dev dependencies

* Add gitignore file

* Add initial version of HQAR models and schema generation functions

* Configure default options for linters and pre-commit

* Format _operation_v1.py

* Add initial version of gh workflow

* Fix maximum Python version in workflow file

* Dummy commit to verify workflows work

* Fix formatting

* Fix typing issue

* Rename DocumentRootV1 to SchemaV1

---------

Co-authored-by: Konrad Jałowiecki <kjalowiecki@psiquantum.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstechly mstechly mstechly approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dexter2206 @mstechly