Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Convert local_variables from list of strings to dictionary #106

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

dexter2206
Copy link
Contributor

@dexter2206 dexter2206 commented Jul 5, 2024

Description

As stated in PsiQ/bartiq#71, we want to change from representing local_variables from list of strings of the form var=expr to a dictionary mapping variables to corresponding expressions. This PR introduces this change to Qref, so there is no discrepancy between Qref and Bartiq.

Please verify that you have completed the following steps

  • I have self-reviewed my code.
  • I have included test cases validating introduced feature/fix.
  • I have updated documentation.

@cla-bot cla-bot bot added the cla-signed label Jul 5, 2024
@dexter2206 dexter2206 requested a review from sitong1011 July 5, 2024 12:48
Copy link
Contributor

@joshes joshes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dexter2206 dexter2206 merged commit 62697e0 into main Jul 9, 2024
7 checks passed
@dexter2206 dexter2206 deleted the convert-local-variables-to-dictionaries branch July 9, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants