Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix! Fix incorrect rendering with graphviz #110

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Conversation

dexter2206
Copy link
Contributor

Description

I noticed that some graphs produced by our graphviz renderer are incorrect. This is because we lacked proper escaping of node names and we had an erroneous space between node name and port. This PR fixes it.

Please verify that you have completed the following steps

  • I have self-reviewed my code.
  • I have included test cases validating introduced feature/fix.
  • I have updated documentation.

Copy link

cla-bot bot commented Jul 12, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Konrad Jałowiecki.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

1 similar comment
Copy link

cla-bot bot commented Jul 12, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Konrad Jałowiecki.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@dexter2206 dexter2206 force-pushed the fix-graphviz-issues branch from 57d5a83 to bce6033 Compare July 12, 2024 14:08
@cla-bot cla-bot bot added the cla-signed label Jul 12, 2024
@dexter2206 dexter2206 merged commit b43313d into main Jul 12, 2024
7 checks passed
@dexter2206 dexter2206 deleted the fix-graphviz-issues branch July 12, 2024 14:09
dexter2206 added a commit that referenced this pull request Jul 12, 2024
* Escape node names and fix incorrect port designation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant