Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix topology verification #123

Merged
merged 7 commits into from
Sep 30, 2024
Merged

fix: Fix topology verification #123

merged 7 commits into from
Sep 30, 2024

Conversation

dexter2206
Copy link
Contributor

Description

Our topology verification did not take into account the through ports, and it also could malform the path at which the problem were reported. This PR fixes this issue. Additionally, this PR fixes an issue with malformed f-string occurring in SchemaV1 validation.

Please verify that you have completed the following steps

  • I have self-reviewed my code.
  • I have included test cases validating introduced feature/fix.
  • I have updated documentation.

@cla-bot cla-bot bot added the cla-signed label Sep 30, 2024
@dexter2206 dexter2206 requested a review from mstechly September 30, 2024 23:35
@dexter2206 dexter2206 merged commit f5a62af into main Sep 30, 2024
6 checks passed
@dexter2206 dexter2206 deleted the fix-topology-verification branch September 30, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants