Fix problem creating columns from PortfolioOverview webpart (Program)…

… [skip-ci]

SharePointFramework/PortfolioWebParts/src/components/PortfolioOverview/ColumnFormPanel/useColumnFormPanel.ts

@@ -32,7 +32,7 @@ export function useColumnFormPanel() {
    * If the column is being edited, it will update the column in the list
    * using `updateItemInList` from the `dataAdapter`. If the column is new,
    * it will add the column to the list using `addColumnToPortfolioView` from
-   * the `dataAdapter`.
+   * the shared `dataAdapter`.
    */
   const onSave = async () => {
     const colummData = column.get('data') ?? {}
@@ -61,7 +61,7 @@ export function useColumnFormPanel() {
         _.omit(columnItem, ['Id', 'GtInternalName', 'GtManagedProperty'])
       )
     } else {
-      await context.props.dataAdapter.addColumnToPortfolioView(
+      await context.props.dataAdapter.portalDataService.addColumnToPortfolioView(
         columnItem,
         context.state.currentView
       )

SharePointFramework/PortfolioWebParts/src/data/index.ts

@@ -763,25 +763,6 @@ export class DataAdapter implements IPortfolioWebPartsDataAdapter {
       throw new Error(format(strings.DataSourceCategoryError, category))
     }
   }
-
-
-
-  public async addColumnToPortfolioView(
-    properties: SPProjectColumnItem,
-    view: PortfolioOverviewView
-  ): Promise<boolean> {
-    try {
-      const projectColumnsList = this._sp.web.lists.getByTitle(strings.ProjectColumnsListName)
-      const portfolioViewsList = this._sp.web.lists.getByTitle(strings.PortfolioViewsListName)
-      const column = await projectColumnsList.items.add(_.omit(properties, ['Id']))
-      portfolioViewsList.items.getById(view.id as any).update({
-        GtPortfolioColumnsId: [...view.columns.map((c) => c.id), column.data.Id]
-      })
-      return true
-    } catch (error) {
-      return false
-    }
-  }
 }
 
 export * from './types'

SharePointFramework/PortfolioWebParts/src/data/types.ts

@@ -280,13 +280,13 @@ export interface IPortfolioWebPartsDataAdapter {
   ): Promise<any[]>
 
   /**
-   * Adds a new column to the project columns list and adds the column to the specified view.
+   * Adds a new column to the project content columns list and adds the column to the specified data source.
    *
    * @param properties Properties for the new column (`Id` will be omitted)
-   * @param view The view to add the column to
+   * @param dataSource The data source to add the column to
    */
-  addColumnToPortfolioView?(
-    properties: SPProjectColumnItem,
-    view: PortfolioOverviewView
+  addColumnToDataSource?(
+    properties: SPProjectContentColumnItem,
+    dataSource: DataSource
   ): Promise<boolean>
 }

SharePointFramework/ProgramWebParts/src/loc/mystrings.d.ts

@@ -110,6 +110,9 @@ declare interface IProgramWebPartsStrings {
   InternalNameLabel: string
   IsGroupableDescription: string
   IsGroupableLabel: string
+  IsRefinableDescription: string
+  IsRefinableLabel: string
+  IsResizableLabel: string
   ListViewText: string
   MaxWidthDescription: string
   MaxWidthLabel: string
@@ -153,6 +156,9 @@ declare interface IProgramWebPartsStrings {
   SearchQueryLabel: string
   ShowCommandBarLabel: string
   ShowExcelExportButtonLabel: string
+  ShowFieldFrontpageLabel: string
+  ShowFieldPortfolioLabel: string
+  ShowFieldProjectStatusLabel: string
   ShowFiltersLabel: string
   ShowGroupByLabel: string
   ShowHideColumnsLabel: string
@@ -169,7 +175,6 @@ declare interface IProgramWebPartsStrings {
   ToggleEditViewColumnsLabel: string
   UseChangesButtonText: string
   ViewNotFoundMessage: string
-
   DataSourceItemNotFound: string
   DataSourceListName: string
   ProjectContentColumnItemNotFound: string

SharePointFramework/ProgramWebParts/src/loc/nb-no.js

@@ -111,6 +111,9 @@ define([], function () {
     InternalNameLabel: 'Internt feltnavn',
     IsGroupableDescription: 'Brukere kan gruppere på denne kolonnen.',
     IsGroupableLabel: 'Grupperbar',
+    IsRefinableDescription: 'Brukere kan filtrere på denne kolonnen.',
+    IsRefinableLabel: 'Presiser',
+    IsResizableLabel: 'Justerbar',
     ListViewText: 'Liste',
     MaxWidthDescription: 'Maksimum bredde for kolonnen. Kan ikke være mindre enn minimum bredde.',
     MaxWidthLabel: 'Maks bredde',
@@ -154,6 +157,9 @@ define([], function () {
     SearchQueryLabel: 'Søkespørring',
     ShowCommandBarLabel: 'Vis kommandolinje',
     ShowExcelExportButtonLabel: 'Vis eksport til Excel-knapp',
+    ShowFieldFrontpageLabel: 'Prosjektforside',
+    ShowFieldPortfolioLabel: 'Porteføljeoversikt',
+    ShowFieldProjectStatusLabel: 'Prosjektstatus',
     ShowFiltersLabel: 'Vis filtre',
     ShowGroupByLabel: 'Vis grupperingsvalg',
     ShowHideColumnsLabel: 'Vis eller skjul kolonner',

SharePointFramework/shared-library/src/services/PortalDataService/PortalDataService.ts

@@ -317,6 +317,29 @@ export class PortalDataService extends DataService<IPortalDataServiceConfigurati
     return spItems.map((item) => new ProjectColumnConfig(item))
   }
 
+  /**
+   * Adds a new column to the project columns list and adds the column to the specified view.
+   *
+   * @param properties Properties for the new column (`Id` will be omitted)
+   * @param view The view to add the column to
+   */
+  public async addColumnToPortfolioView(
+    properties: SPProjectColumnItem,
+    view: PortfolioOverviewView
+  ): Promise<boolean> {
+    try {
+      const projectColumnsList = this._getList('PROJECT_COLUMNS')
+      const portfolioViewsList = this._getList('PORTFOLIO_VIEWS')
+      const column = await projectColumnsList.items.add(_.omit(properties, ['Id']))
+      portfolioViewsList.items.getById(view.id as any).update({
+        GtPortfolioColumnsId: [...view.columns.map((c) => c.id), column.data.Id]
+      })
+      return true
+    } catch (error) {
+      return false
+    }
+  }
+
   /**
    * Get portfolio overview views. Returns all shared views and personal views.
    */