Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #856 by ignoring combining diacritics when computing line length #869

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

reynoldsnlp
Copy link

I also alphabetized the import statements by moving bisect to the top.

I also alphabetized the import statements by moving `bisect` to the top.
@asottile
Copy link
Member

Can you write a test demonstrating this change (and so it doesn't regress) -- thanks for your contribution! 🎉

@reynoldsnlp reynoldsnlp changed the title Fix #856 Fix #856 by ignoring combining diacritics when computing line length May 30, 2019
@reynoldsnlp
Copy link
Author

@asottile I'm not sure I wrote that test correctly, so make sure you think it looks good.

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test looks good 👍

pycodestyle.py Outdated Show resolved Hide resolved
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg2m!

@reynoldsnlp
Copy link
Author

Thanks for your help! I'll be very happy to have that fixed.

@reynoldsnlp
Copy link
Author

Do the checks need to be restarted?

@sigmavirus24
Copy link
Member

Can you rebase? I expect the checks will run correctly then if you rebase and force-push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants