Adding jax backend #562
Closed
Adding jax backend #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VascoSch92
reviewed
Feb 1, 2024
VascoSch92
reviewed
Feb 1, 2024
pylops/jaxoperator.py
Outdated
|
|
||
| class JaxOperator(LinearOperator): | ||
| def __init__(self, Op): | ||
| super().__init__(dtype=Op.dtype, dims=Op.dims, dimsd=Op.dimsd, name=Op.name) |
There was a problem hiding this comment.
if you put a comma at the end it will be more readable
There was a problem hiding this comment.
not sure what you mean...
|
@VascoSch92 thanks for the comments! This is a very early days draft so we will clean things up later when the full structure is in place :) |
No problem :-) I will wait for the final version ;-) |
|
@VascoSch92 see #590 if still interested to review with PR :) I will soon close this one... |
|
I will give a look tomorrow :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP... moved to #590