-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ToCupy operator #622
Conversation
@cako I'd like to hear your opinion on this before implementing the changes to all the other solvers. Basically when I started to work on this I wasn't sure how much effort it would be required to have these sort of mixed CPU-GPU operators (and inverse problems). It turned out to be easier than expected, but it required some modifications to the solvers (hidden from the user) and the introduction of a new optional parameter for the stacking operators to be able to handle case 4 in #620. To handle case 3, it is instead simply required to have this new Examples: https://github.com/PyLops/pylops_notebooks/blob/master/developement-cupy/ToCupy.ipynb |
Looks really good! The only part I'd say could be improved is the documentation. |
@cako what about now? I added 3 graphics for end-to-end GPU, and the 2 mixed scenarios 😄 |
Looks awesome!! Super clear now! |
Addresses #620