Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ToCupy operator #622

Merged
merged 6 commits into from
Nov 24, 2024
Merged

feat: ToCupy operator #622

merged 6 commits into from
Nov 24, 2024

Conversation

mrava87
Copy link
Collaborator

@mrava87 mrava87 commented Nov 18, 2024

Addresses #620

@mrava87
Copy link
Collaborator Author

mrava87 commented Nov 18, 2024

@cako I'd like to hear your opinion on this before implementing the changes to all the other solvers.

Basically when I started to work on this I wasn't sure how much effort it would be required to have these sort of mixed CPU-GPU operators (and inverse problems). It turned out to be easier than expected, but it required some modifications to the solvers (hidden from the user) and the introduction of a new optional parameter for the stacking operators to be able to handle case 4 in #620. To handle case 3, it is instead simply required to have this new ToCupy operator...

Examples: https://github.com/PyLops/pylops_notebooks/blob/master/developement-cupy/ToCupy.ipynb

docs/source/gpu.rst Outdated Show resolved Hide resolved
docs/source/gpu.rst Outdated Show resolved Hide resolved
docs/source/gpu.rst Outdated Show resolved Hide resolved
docs/source/gpu.rst Outdated Show resolved Hide resolved
@cako
Copy link
Collaborator

cako commented Nov 23, 2024

Looks really good! The only part I'd say could be improved is the documentation.

@mrava87
Copy link
Collaborator Author

mrava87 commented Nov 24, 2024

@cako what about now? I added 3 graphics for end-to-end GPU, and the 2 mixed scenarios 😄

@mrava87 mrava87 marked this pull request as ready for review November 24, 2024 11:56
@cako
Copy link
Collaborator

cako commented Nov 24, 2024

Looks awesome!! Super clear now!

@cako cako merged commit 2d749a2 into PyLops:dev Nov 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants