Skip to content

Commit

Permalink
Revert "Ignore cffi installation error" (#285)
Browse files Browse the repository at this point in the history
This reverts commit f61caa2.

`cffi` now supports, and provide wheels for, Python 3.13
(https://github.com/python-cffi/cffi/releases/tag/v1.17.0), so this
should work as expected on 3.13.
  • Loading branch information
mkniewallner authored Sep 7, 2024
1 parent 3c71407 commit b234962
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
4 changes: 1 addition & 3 deletions dist/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -12037,9 +12037,7 @@ async function hostBuild(maturinRelease, args) {
core.info(`Installing 'maturin' from tag '${maturinRelease}'`);
const maturinPath = await installMaturin(maturinRelease);
await exec.exec(maturinPath, ['--version'], { ignoreReturnCode: true });
await exec.exec('python3', ['-m', 'pip', 'install', 'cffi'], {
ignoreReturnCode: true
});
await exec.exec('python3', ['-m', 'pip', 'install', 'cffi']);
if (IS_LINUX) {
await exec.exec('python3', ['-m', 'pip', 'install', 'patchelf']);
}
Expand Down
4 changes: 1 addition & 3 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -878,9 +878,7 @@ async function hostBuild(
core.info(`Installing 'maturin' from tag '${maturinRelease}'`)
const maturinPath = await installMaturin(maturinRelease)
await exec.exec(maturinPath, ['--version'], {ignoreReturnCode: true})
await exec.exec('python3', ['-m', 'pip', 'install', 'cffi'], {
ignoreReturnCode: true
})
await exec.exec('python3', ['-m', 'pip', 'install', 'cffi'])
if (IS_LINUX) {
await exec.exec('python3', ['-m', 'pip', 'install', 'patchelf'])
}
Expand Down

0 comments on commit b234962

Please sign in to comment.