Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Interpreter Argument for pep517 sdist Generation #2283

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

paddonizio
Copy link

  • Fixes Maturin sdist Generation Fails When Using --no-isolation #2245
  • Adds an interpreter argument to maturin's pep517 sdist generation, causing maturin to skip the interpreter resolution step.
  • Adds --interpreter _get_sys_interpreter() to the init.py command invoking the maturin binary to ensure sdist generation uses the interpreter maturin was invoked with.

@paddonizio
Copy link
Author

I didn't see any tests covering the areas I was changing, but let me know if I missed something and I can add some.

Copy link
Member

@messense messense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, looks good to me as a workaround, but I guess the proper fix would be skipping python interpreter discovery during sdist build, I wonder how hard that will be, will take a look later when I'm free.

@messense
Copy link
Member

messense commented Nov 6, 2024

but I guess the proper fix would be skipping python interpreter discovery during sdist build, I wonder how hard that will be, will take a look later when I'm free.

Hi @paddonizio can you try #2292, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maturin sdist Generation Fails When Using --no-isolation
2 participants