-
-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Interpreter Argument for pep517 sdist Generation #2283
base: main
Are you sure you want to change the base?
Conversation
I didn't see any tests covering the areas I was changing, but let me know if I missed something and I can add some. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, looks good to me as a workaround, but I guess the proper fix would be skipping python interpreter discovery during sdist build, I wonder how hard that will be, will take a look later when I'm free.
Hi @paddonizio can you try #2292, thanks! |
--interpreter _get_sys_interpreter()
to the init.py command invoking the maturin binary to ensure sdist generation uses the interpreter maturin was invoked with.