Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add validator report #1294

Closed
wants to merge 1 commit into from
Closed

add validator report #1294

wants to merge 1 commit into from

Conversation

lkstrp
Copy link
Member

@lkstrp lkstrp commented Sep 13, 2024

Adds Validator CI. See the report below.

  • It is triggered by any new commit in pr.

  • Runs on a self-hosted github runner and solves on z1, so basically any configuration can be set. No restrictions. It just takes a while to update the comment if you choose a computationally intensive config.

  • Compares the base branch (main) with the latest commit in the pr branch. So runs both, but also caches (in addition to snakemake caching) based on commit hashes. - Edits one main report comment when new commits are pushed to the repo, to avoid spamming.

  • Set all settings in workflow file (mainly which plots to show, pre-commands, environment selection, etc.)

  • Some things which are missing:

    • Better comparison (use n.statistics)
    • Handle environment updates
    • More file filters to avoid unnecessary runs
    • Concurrency

Also have a look at the Wishlist and see action repo to create any issues. This will be moved to the PyPSA org at some point.

@lkstrp
Copy link
Member Author

lkstrp commented Sep 13, 2024

See #1295

@lkstrp lkstrp closed this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant