-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: only add waste chp to buses which have urban central heat buses #1407
Conversation
Validator ReportI am the Validator. Download all artifacts here. General Files comparison
NRMSE: Normalized (combined-min-max) Root Mean Square Error Model Metrics Comparing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, but could make sense to add WtE everywhere but keep bus2 empty when urban central heat is not available.
Good to go once tested it doesn't cause any infeasibilities.
yes, this would be a better approach, because co2 could be like AC nodes available for every location. For me considering all nodes and also non existing urban central heat nodes did not cause infeasibilities, just a warning that bus does not exist. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think this is better!
Closes # (if applicable).
Changes proposed in this Pull Request
Checklist
envs/environment.yaml
.config/config.default.yaml
.doc/configtables/*.csv
.doc/data_sources.rst
.doc/release_notes.rst
is added.