Tracab Meta added (V4) #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 27, 2024 12:34
|
The tests seem to fail at a random file I didn't touch? |
Was just sniffing around this issue. Seems like the git actions fail on the formatting of |
|
I see my commit contains that file, in a slightly different format. Weird 🤷♀️ |
|
I had black version 23.3.0 instead of 22.3.0... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added an option for reading yet another version of the Tracab Meta data (as requested by here #352)
My main concern is the ever growing amount of random Tracab Meta file configurations, but for now this implementation should hold. Not sure how to approach this other than wait for issues to be raised...
It first checks if there is a "match" attribute in the meta_data and if not it will check a key I have yet only seen in this new version of the meta data (
Phase1StartFrame). Additionally there are some small additions to make the create_team function a bit more flexible because some tags have slightly changed in this version.<Player>became<item>and<TeamId>became<TeamID>(same for player ids).I've also added new tests.